Change in vdsm[master]: Change safelease APIs to match SANLock flow

fsimonce at redhat.com fsimonce at redhat.com
Mon Jan 30 16:33:01 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Change safelease APIs to match SANLock flow
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 921:         # since the domain will be deactivated
If we stop the spm first we don't know how long the umount will take (or even if it fails) and we might end up with two SPMs with the master mounted. Do you want to split this change out?

--
To view, visit http://gerrit.ovirt.org/221
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39d5410ad76b22b037e8cac7e667817fb9ef56f6
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list