Change in vdsm[master]: [WIP] Adding flowID

danken at redhat.com danken at redhat.com
Mon Jan 30 08:16:03 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Adding flowID
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/clientIF.py
Line 75:                 argsStr  = str(args).split(",")
parsing strings is slow and error prone. We have easily accessible in-memory objects, let us use them.

Line 100:                logStr += " flowID [%s]" % argsDict['flowID']
As I told you privately, you can start with logging on API entry.

--
To view, visit http://gerrit.ovirt.org/1221
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>


More information about the vdsm-patches mailing list