Change in vdsm[master]: [WIP] Adding flowID

danken at redhat.com danken at redhat.com
Fri Jan 27 20:42:56 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Adding flowID
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/clientIF.py
Line 75:                 argsStr  = str(args).split(",")
I do not understand what's going on here. Are you converting the arguments to a string and then back to a dictionary? Why? you should look for a dict in args list.

Line 100:                logStr += " flowID [%s]" % argsDict['flowID']
logging flowID on API entry point is nice, but was deemed not enough.
Please consider writing a LogAdapter that prints it from threadLocal.

--
To view, visit http://gerrit.ovirt.org/1221
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>


More information about the vdsm-patches mailing list