Change in vdsm[master]: BZ#769502 Don't invalidate the cache on lv activation

smizrahi at redhat.com smizrahi at redhat.com
Tue Jan 24 22:14:28 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: BZ#769502 Don't invalidate the cache on lv activation
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/storage/lvm.py
Line 731:         changelv(vg, lvs, "--available", available, False)
That's just unrelated.

hsm.deactivate
hsm.some_operation_ that_ refreshes_the_cache
spm.change
hsm.activate

You are still stale.
Just refreshing manicly isn't the way to fix this issue.
To find a FAST way to check if the cache is stale (gen number on the VG anyone?) is the way to mediate this and it is still not race proof.

--
To view, visit http://gerrit.ovirt.org/675
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list