Change in vdsm[master]: added mtu support for network interface

smizrahi at redhat.com smizrahi at redhat.com
Mon Jan 23 22:22:10 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: added mtu support for network interface
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 223:             s = s + 'MTU=%s\n' % pipes.quote(mtu)
Use %d, we do want it to fail if it's not a number

Line 312:         ''' method Search entry in conffile and return 
Rouge space

--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list