Change in vdsm[master]: added support for mirror promisc mode

smizrahi at redhat.com smizrahi at redhat.com
Mon Jan 23 22:14:29 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(7 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1480:     def _releasePromiscNetwork(self, networkName):
This whole function looks like it needs to be in it's own module

Line 1489:         command = ['/sbin/tc', 'qdisc', 'del', 'dev', networkName, 'root']
Why did you put the path in constants if your not going ot use it?
Anyway please thinly wrap TC phonically in a file (tc.py?) and then use the methods everywhere else.

Line 1490:         retcode, out, err = utils.execCmd(command, sudo=True, raw=True)
Use supervdsm for root operations

Line 1492:             e = errmsg % (' '.join(command), err)
use subprocess.list2cmdline()

Line 1493:             self.log.error(e)
consider using exc_info=True

Line 1502:         command = ['/sbin/ifconfig', networkName, '-promisc']
Please do the same for ifconfig

Line 1508:     def _capturePromiscNetwork(self, networkName, ifaceName, mode):
This one might join the other one in the aforementioned module

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list