Change in vdsm[master]: API: Separate clientIF and the xmlrpc server

agl at us.ibm.com agl at us.ibm.com
Mon Jan 23 14:52:30 UTC 2012


Adam Litke has posted comments on this change.

Change subject: API: Separate clientIF and the xmlrpc server
......................................................................


Patch Set 2: (4 inline comments)

....................................................
File vdsm/clientIF.py
Line 62: class bindingXMLRPC:
Done

Line 66:         self.serverPort = config.get('addresses', 'management_port')
Done

Line 77:         self.server.timeout = 1
I am not sure either.  It might not be important to expose this option to the users.  Either way, could we postpone that for a future series to avoid mixing too many unrelated changes into the API refactoring?

Line 343:     def getGlobalMethods(self):
Yes, I kept that intact for the HSM methods, but for the methods that are in clientIF, I did not see a benefit in adding all of that glue since only the xmlrpc binding needs it.  In a later patch, this will be moved into the API class anyhow.

--
To view, visit http://gerrit.ovirt.org/620
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list