Change in vdsm[master]: vdsm/Makefile.am: fix make install

danken at redhat.com danken at redhat.com
Sun Jan 22 21:11:18 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm/Makefile.am: fix make install
......................................................................


Patch Set 1: Looks good to me, approved

Douglas, go ahead and remove vdsm-gencerts.sh from dist (vdsm.spec is there intentionally).

I usually like verbosity, but I agree with Federico, that in this case the comment is less useful than an explanation why the bug popped up, and how it was solved.

--
To view, visit http://gerrit.ovirt.org/1124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6488114ad6bbdd666f5309fbb943e04c4f558f75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list