Change in vdsm[master]: Remove the _preparedDrives dictionary from vm
ilvovsky at redhat.com
ilvovsky at redhat.com
Sat Jan 21 12:50:10 UTC 2012
Igor Lvovsky has posted comments on this change.
Change subject: Remove the _preparedDrives dictionary from vm
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vm.py
Line 575: # a race with _cleanup
Yep, you right. It looks like we still need self._volPrepareLock between prepare and _cleanup
Line 861: drive, exc_info=True)
You are right it shouldn't be True.
--
To view, visit http://gerrit.ovirt.org/1123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d310f216987b7ded89e71752464934f70c051ad
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list