Change in vdsm[master]: Use SANLock for the SPM resource

danken at redhat.com danken at redhat.com
Fri Jan 20 22:29:10 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Use SANLock for the SPM resource
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 660:             freeSlot += 1
shouldn't this fail if all slots in _getLeasesFilePath() are exhausted?

....................................................
File vdsm/storage/safelease.py
Line 150:         return 250
is this related to MAX_HOST_ID?

--
To view, visit http://gerrit.ovirt.org/726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list