Change in vdsm[master]: Do not lock the image when preparing the VM path

danken at redhat.com danken at redhat.com
Fri Jan 20 21:26:01 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Do not lock the image when preparing the VM path
......................................................................


Do not lock the image when preparing the VM path

Since the resource manager scope is local there is no need for a VM
to take an exclusive lock on the images: in fact the SPM running on
an other machine could still manipulate such images.
Using the resource manager in general on HSM is wrong because it is
mapped on actions that are valid only on the SPM such as: modifing
the lvm permissions and the modification time in the metadata.

In this patch:
* add an activate/deactivate image method to StorageDomain
* implement the activate/deactivate image for BlockStorageDomain
* add the prepareImage/teardownImage methods in HSM

Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
---
M vdsm/clientIF.py
M vdsm/storage/blockSD.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/sd.py
5 files changed, 109 insertions(+), 11 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list