Change in vdsm[master]: Use SANLock for the SPM resource

ilvovsky at redhat.com ilvovsky at redhat.com
Wed Jan 18 15:07:18 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Use SANLock for the SPM resource
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

Only minor issue in delete flow

....................................................
File vdsm/storage/fileVolume.py
Line 237:             self.oop.fileUtils.cleanupfiles([vol_path])
Probably you need to remove .lease file here

--
To view, visit http://gerrit.ovirt.org/726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list