Change in vdsm[master]: Add an object model to clientIF

smizrahi at redhat.com smizrahi at redhat.com
Mon Jan 16 18:18:45 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Add an object model to clientIF
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

There are stuff here that I don't agree with like Volume having an object and some of the API semantics but these should be discussed unrelated to the actual code concept.

I do agree with the general fact that we should have a group f objects mapping to logical units inside VDSM.

API.py I would like to see the module in lower case and maybe have a more indicative name but this can be done later.

--
To view, visit http://gerrit.ovirt.org/984
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee54277c87a02ac8dafe29a8761e2acf0f7397f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list