Change in vdsm[master]: Avoid to activate parent volume on cloning

ilvovsky at redhat.com ilvovsky at redhat.com
Fri Jan 13 13:54:46 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Avoid to activate parent volume on cloning
......................................................................


Patch Set 7: Looks good to me, but someone else must approve

(2 inline comments)

Two minor comments

....................................................
File vdsm/storage/volume.py
Line 870:         # cwd = os.path.split(os.path.split(volume)[0])[0]
Why this dead code?

Line 872:         # Temprary fix for qemu-img creation problem
Is this still relevant?

--
To view, visit http://gerrit.ovirt.org/570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list