Change in vdsm[master]: Add support of stable PCI addresses.

danken at redhat.com danken at redhat.com
Wed Jan 11 12:56:06 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Add support of stable PCI addresses.
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(5 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 829:         if getattr(self, 'address', False):
getattr -> hasattr is clearer in this context

Line 1437:             devxml = xml.dom.minidom.parseString(self._dom.XMLDesc(0)) \
XMLDesc() may block, better use self._lastXML

it may make sense to cache hash(_lastXML) to avoid recalculation every 2 seconds.

Line 1454:             controller = adrXml.getAttribute('controller')
consider iterating over all exiting attributes. I'm not sure we should enforce the libvirt address standard. libvirt is good enough for that.

 for k in d.childNodes[0].attributes.keys():
    print k, '=', d.childNodes[0].getAttribute(k)

Line 1473:         videosxml = xml.dom.minidom.parseString(self._dom.XMLDesc(0)) \
maybe we can avoid reading the same XMLDesc again and again (and use our cache instead)

Line 1482:             # Video card device have not unique identifier, except the alias
devices have,
device has

--
To view, visit http://gerrit.ovirt.org/235
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3a97fa998d0f52ebe752024c62b8ec16c32c78
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list