Change in vdsm[master]: Specify which user/group should be used for core dumps rotat...

fsimonce at redhat.com fsimonce at redhat.com
Tue Jan 10 11:15:22 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Specify which user/group should be used for core dumps rotation
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm.spec.in
Line 34: Requires: logrotate >= 3.8.0
If this is different in fedora/rhel, split it in the %if 0%{?rhel}/%else parts.

....................................................
File vdsm/vdsm-logrotate.conf.in
Line 19:     su @VDSMUSER@ @VDSMGROUP@
Make this as a complete macro eg: @LOGROTATE_SU_CONFIG@ which is empty on rhel (you should detect that on configure, probably checking the logrotate version).

--
To view, visit http://gerrit.ovirt.org/971
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: mhuntxu at gmail.com


More information about the vdsm-patches mailing list