Change in vdsm[master]: Change device ownership for VM's drives.

ilvovsky at redhat.com ilvovsky at redhat.com
Sun Jan 8 07:56:41 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Change device ownership for VM's drives.
......................................................................


Patch Set 2: (3 inline comments)

only minor comments

....................................................
File vdsm/clientIF.py
Line 587:                 res = self.irs.appropriateVolume(drive["GUID"], vmId)
I don't like appropriateVolume name, it's not really fits what this function does.
But I have not a good idea for better one, so ... (maybe ask our names committee)

....................................................
File vdsm/storage/hsm.py
Line 2401:     def public_appropriateVolume(self, guid, thiefId):
please change the thiefId to something else.

....................................................
File vdsm/supervdsmServer.py
Line 154:         cmd =  ['udevadm', 'trigger', '--verbose', '--action', 'change',
why it's not in const ?

--
To view, visit http://gerrit.ovirt.org/904
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7859635b8abed67fe006886efd500eb9ac9f3b7c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list