Change in vdsm[master]: Move domain monitor out of sp.py

danken at redhat.com danken at redhat.com
Fri Jan 6 15:20:25 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Move domain monitor out of sp.py
......................................................................


Patch Set 19: (1 inline comment)

....................................................
File vdsm/storage/domainMonitor.py
Line 29:             "vgMdFreeBelowThreashold")
I don't like the paradigm, as it requires changing a property name in two places. but ok.

--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ilvovsky at gmail.com


More information about the vdsm-patches mailing list