Change in vdsm[master]: Use a copy of the domainsToUpgrade

danken at redhat.com danken at redhat.com
Thu Jan 5 09:34:57 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Use a copy of the domainsToUpgrade
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

please mention the rhel-6.3.0 bug in the commit message. it would later have to be backported into 6.2.z.

....................................................
File vdsm/storage/sp.py
Line 391:             domains = self._domainsToUpgrade[:]
why do you even need this variable? just put the list copy operation in line 406

--
To view, visit http://gerrit.ovirt.org/900
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3de0646af2fe9a9fcde708837cfcd83d10385026
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list