Change in vdsm[master]: Replace most traceback.format_exc() calls by exc_info

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Tue Feb 28 15:13:41 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................


Patch Set 2: (2 inline comments)

Thanks for the feedback, patch set 3 incoming.

....................................................
File vdsm/storage/misc.py
Line 150:     log.error("Panic: %s" % (str(msg)), exc_info=True)
This was already there, but since we're touching the line anyway I'll fix this. I think the str() is also redundant.

....................................................
File vdsm/utils.py
Line 127:                     logging.debug("Could not read %s" % f, exc_info=True)
Done

--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>


More information about the vdsm-patches mailing list