Change in vdsm[master]: Added blkid tool support in supervdsm.

danken at redhat.com danken at redhat.com
Tue Feb 28 09:14:01 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added blkid tool support in supervdsm.
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/blkid.py
Line 48:     blkIdDict = dict(map(lambda x: x.split('=', 1), out))
oh, I did not notice that you've dropped the multiple-device/ all-device option and move to a single device. Why have you done that? Wouldn't it waste too much executions of blkid?

--
To view, visit http://gerrit.ovirt.org/2185
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list