Change in vdsm[master]: vm payload: add file injection to vm

shavivi at redhat.com shavivi at redhat.com
Mon Feb 27 12:43:06 UTC 2012


Shahar Havivi has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 1: (14 inline comments)

....................................................
File vdsm/supervdsmServer.py
Line 40: import constants
Done

Line 46: PAYLOAD_PREFIX_PATH = '/var/run/vdsm/payload/'
Done

Line 186:     def _commonMkFs(self, files):
why not

Line 194:             for name in entry.iterkeys():
look at vm.py in the new patch

Line 199:                 os.chown(filename, uid, gid) 
Done

Line 205:     def _commonCleanFs(self, files, dirname, media):
suggestions?

Line 208:         os.chown(media, uid, gid)
because mkisofs creating the file as root

Line 224:                     code %s, out %s\nerr %s" % (str(rc), out, err))
Done

Line 231:                     code %s, out %s\nerr %s" % (str(rc), out, err))
Done

Line 240:                     code %s, out %s\nerr %s" % (str(rc), out, err))
Done

Line 255:                     code %s, out %s\nerr %s" % (str(rc), out, err))
Done

....................................................
File vdsm/vm.py
Line 431:         if self.conf.has_key('vmPayload'):
well we decided (me and Eduardo) that it will be better to make the device here.

Line 437:             drv['iface'] = 'ide'
virtio will be sufficient here?

Line 438:             for key, files in self.conf.get('vmPayload'):
Done

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list