Change in vdsm[master]: Added blkid tool support in supervdsm.

barumuga at redhat.com barumuga at redhat.com
Fri Feb 24 05:30:59 UTC 2012


Bala.FA has posted comments on this change.

Change subject: Added blkid tool support in supervdsm.
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File vdsm/blkid.py
Line 29:         rc, out, err = utils.execCmd([constants.EXT_BLKID, "-c", "/dev/null"],
That's right.  How do we react on empty value like None,(),'' etc passed for devList?  Can we ignore and let exception occurs?

Line 31:     if rc:
Done

Line 33:     blkIdDict = {}
Parsing will be done in a separate function. It works fine for 'blkid -c /dev/null' output.
I would like to know is whether we need to consider non-blkid output and other variant output of blkid?

--
To view, visit http://gerrit.ovirt.org/2185
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list