Change in vdsm[master]: ISCSI Subsystem refactoring

smizrahi at redhat.com smizrahi at redhat.com
Mon Feb 20 17:20:35 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: ISCSI Subsystem refactoring
......................................................................


Patch Set 5: (4 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 2294:         if username or password:
I left 2288 as is because of BC. technically we should get rid of it when possible. The semantics are different as if username is None, but password is not None my code will trigger.

Line 2303:             fullTargets.append("%s:%d,%d %s" % (target.portal.host, target.portal.port, target.tpgt, target.iqn))
graaa!

....................................................
File vdsm/storage/iscsiadm.py
Line 10: class IscsiError(RuntimeError): pass
It is, I also put it in my comment that both of them are codependent. The things is that they are both pretty big with wordy commit messages and squashing them will make reviewing a bit more confusing. IMHO.

....................................................
File vdsm/storage/Makefile.am
Line 39:         iscsiadm.py \
Graa.

--
To view, visit http://gerrit.ovirt.org/1607
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list