Change in vdsm[master]: task.py: avoid overtly silly casting to str()

danken at redhat.com danken at redhat.com
Sun Feb 19 15:58:45 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: task.py: avoid overtly silly casting to str()
......................................................................


task.py: avoid overtly silly casting to str()

For a reason unknown (to me), task.py does not use pickle to persist its
data to file. We cannot fix that without breaking
backward-compatibility. However, we can avoid pointless casts to str,
and can encode data to utf8 before storing to disk.

Note that this patch does not solve BZ#567077 as the storage subsystem
prevents entry of Unicode arguments. This prevention must be kept
for old storage domain formats.

Change-Id: I97db724db436e99b95c3524e70fab540f7191334
---
M vdsm/storage/task.py
1 file changed, 48 insertions(+), 50 deletions(-)

Approvals:
  Haim Ateya: Verified
  Eduardo: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/1622
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>


More information about the vdsm-patches mailing list