Change in vdsm[master]: BZ#790014 Fix multiple issues in detachSD

danken at redhat.com danken at redhat.com
Sun Feb 19 14:54:04 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#790014 Fix multiple issues in detachSD
......................................................................


BZ#790014 Fix multiple issues in detachSD

In this patch:
* Remove __unmountLastMaster, the manager cannot deactivate the master
  storage domain (where the SPM resource is hold)
* Move all the checks related to the master migration inside masterMigrate
* detachSD cannot be used to migrate a master

Note that this patch makes it possible to deactivate a master domain
(thus breaking the pool) even if there are other active domains in the
pool. A future patch should discuss if reverting to the old semantics is
necessary, and if so - how it should be done.

Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
2 files changed, 81 insertions(+), 98 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list