Change in vdsm[master]: Clean libvirt networks if bridge not exists

shavivi at redhat.com shavivi at redhat.com
Thu Feb 16 12:15:47 UTC 2012


Shahar Havivi has posted comments on this change.

Change subject: Clean libvirt networks if bridge not exists
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File vdsm/clientIF.py
Line 114:         lvNetworks = self._libvirt.listNetworks()
Done

Line 123:             if netinfo.getnetworks()[network]['bridged'] and network not in netinfo.bridges():
I would cache it locally because it is dynamic after all...

....................................................
File vdsm/configNetwork.py
Line 650:         logging.debug('failed to remove libvirt network %s' % netName)
Done

....................................................
File vdsm/netinfo.py
Line 58: def getnetworks():
Done

--
To view, visit http://gerrit.ovirt.org/1990
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list