Change in vdsm[master]: A new method to read from VMs' channels.

smizrahi at redhat.com smizrahi at redhat.com
Thu Feb 16 00:17:56 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: A new method to read from VMs' channels.
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(3 inline comments)

....................................................
File vdsm/guestIF.py
Line 68:         utils.execCmd([constants.EXT_PREPARE_VMCHANNEL, self._socketName])
error checking?

Line 69:         # Set a timeout for connect retires.
Kinda stating the obvious

Line 76:             logging.debug("Attempting connection to %s", self._socketName)
self.log

--
To view, visit http://gerrit.ovirt.org/869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list