Change in vdsm[master]: BZ#790014 Fix multiple issues in detachSD

abaron at redhat.com abaron at redhat.com
Tue Feb 14 15:21:19 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#790014 Fix multiple issues in detachSD
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File vdsm/storage/sp.py
Line 941:     def detachSD(self, sdUUID, msdUUID=None, masterVersion=None):
msdUUId and version are never used, why are these in the API?

Line 961:             raise se.StorageDomainActive(sdUUID)
I think lines 953-961 should be removed...
detach and forcedDetach should already take care of this.

--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list