Change in vdsm[master]: Log exceptions when calling irs functions from XMLRPC (V3)

danken at redhat.com danken at redhat.com
Tue Feb 14 09:58:58 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Log exceptions when calling irs functions from XMLRPC (V3)
......................................................................


Log exceptions when calling irs functions from XMLRPC (V3)

Changes since V2:
 - Use style log.error("error message", exc_info=True)
Changes since V1:
 - Return errcode['unexpected'] instead of raising an exception

An earlier change I made introduced a bug in API.py that triggered an exception
when calling the 'getDeviceList' XMLRPC call.  Unfortunately the server-side
exception was not logged anywhere (which made debugging more difficult).  This
patch adds exception logging for irs methods (note: wrapApiMethod already does
this for the other calls).

Change-Id: Ifd560d3b110c91f5019c5a6af477926a1fbf1996
Signed-off-by: Adam Litke <agl at us.ibm.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/1575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd560d3b110c91f5019c5a6af477926a1fbf1996
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list