Change in vdsm[master]: add/del network - add bridgesless network

shavivi at redhat.com shavivi at redhat.com
Mon Feb 13 07:54:12 UTC 2012


Shahar Havivi has posted comments on this change.

Change subject: add/del network - add bridgesless network
......................................................................


Patch Set 9: (6 inline comments)

....................................................
File vdsm/clientIF.py
Line 118:                 configNetwork.createLibvirtNetwork(network, True, None)
Done

....................................................
File vdsm_cli/vdsClient.py
Line 1424:         for k in ['bridge', 'vlan', 'bond', 'nics', ]:
Done

....................................................
File vdsm/netinfo.py
Line 26: from fnmatch import fnmatch
Done

Line 59:     Get dict of birdgeless networks
actually it is only bridgeless networks,
in bridged networks we have no interfaces this is the reason for the if statement in line 71

Line 348:         nics = []
Done

Line 354:                 port = nic
right,
I will fix it

--
To view, visit http://gerrit.ovirt.org/848
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a3efea92312ac628e0373a5c29fbb1669058f4
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list