Change in vdsm[master]: Implement __hash__ for mount objects

danken at redhat.com danken at redhat.com
Wed Feb 8 20:31:26 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Implement __hash__ for mount objects
......................................................................


Patch Set 1: (1 inline comment)

we sit in different continents and time zones. please explain why object.__hash__ is not good enough.

....................................................
File vdsm/storage/mount.py
Line 99:         hsh ^= hash(self.fs_file)
if someone ever inherits Mount (even Saggi disallow inheritance), their object refering same spec/file should not equal Mount's.

--
To view, visit http://gerrit.ovirt.org/1691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I771eff8c87a1f4f96dd7e743af69f6c941ac7180
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list