Change in vdsm[master]: added support for mirror promisc mode

smizrahi at redhat.com smizrahi at redhat.com
Wed Feb 8 15:36:36 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/tc.py
Line 23: class MirrorPromisc():
You misunderstood.

You need tc.py which is a thin wrapper around the tc tool

tc.py
--------
def qdisc_add(networkname):
                command = [EXT_TC, 'qdisc', 'add', 'dev', networkName, 'ingress']
	        retcode, out, err = storage.misc.execCmd(command, raw=True, sudo=False)
	        if retcode != 0:
	            e = errmsg % (list2cmdline(command), err)
	            raise Exception(e)

def qdisc_replace(networkName, parent='root'):
  .....

I think you got the point
---------------

Now that you have a thin wrapper around tc in tc.py

create a method called set\unsetPromisc(nics) somewhere else (not in the thin wrapper as this uses more then 1 thinly wrapped calls

Have them accessible through supervdsm

use them in your code.

The class is overkill in any case as there is no reason to hold the state.

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list