Change in vdsm[master]: ISCSI Subsystem refactoring

ilvovsky at redhat.com ilvovsky at redhat.com
Tue Feb 7 09:53:20 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: ISCSI Subsystem refactoring
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

Only minor style comment.
It's pretty hard to review patch like this, I hope that  I didn't missed things. 
But for sure it should pass a pre-integ team

....................................................
File vdsm/storage/multipath.py
Line 298:                     knownSessions[sessionID] = sessionInfo
Ah, this function so big and so ugly. Can you at least refactor out  this part to something  like _normalizeSessionInfo(...)
I did it when I needed to keep BC things in createVM

--
To view, visit http://gerrit.ovirt.org/1607
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list