Change in vdsm[master]: BZ#787594 - set securityOverride=True for unsecured function...

danken at redhat.com danken at redhat.com
Mon Feb 6 10:17:29 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#787594 - set securityOverride=True for unsecured function trying to write to metadata in forceFreeSpm flow
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

two minor comments + you do not need to open a bug for upstream fixes.

....................................................
Commit Message
Line 7: BZ#787594 - set securityOverride=True for unsecured function trying to
subject line must be shorter.

enable fenceSpmStorage on hsm nodes

now explain WHY not HOW

....................................................
File vdsm/storage/sp.py
Line 148:         self.setMetaParams({PMDK_SPM_ID: -1, PMDK_LVER: -1}, __securityOverride=True)
keep line shorter than 80, please.

--
To view, visit http://gerrit.ovirt.org/1642
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>


More information about the vdsm-patches mailing list