Change in vdsm[master]: ISCSI Subsystem refactoring

smizrahi at redhat.com smizrahi at redhat.com
Fri Feb 3 22:16:47 UTC 2012


Saggi Mizrahi has uploaded a new change for review.

Change subject: ISCSI Subsystem refactoring
......................................................................

ISCSI Subsystem refactoring

Currently the iscsi subsystem is a mess of list concatenation.
This refactoring ties to:
    - Make variable and object naming consistent and in line with iscsi
      terminology.
      Note that:
        * portal now refres to an ISCSI Portal and not a tpgt
        * tpgt now refres to tpgt
        * ISCSI interfaces are modeled so that initiator name is actually
          property of the interface and not it's identity
    - Make a coherent object hierarchy of the ISCSI objects. Functions now
      expect to get ISCSI objects (like portal, target) instead of
      scattered arguments that have to be validated and parsed every
      time.
    - Make the ISCSI interface a 1st class member. Up until now support
      for multiple interfaces was amateurish at best.
    - Support for different credentials for discovery and target. Ground
      work to support authentication methods other then CHAP.
    - Thin wrap around iscsiadm to separate cmdline parsing from actual
      VDSM iscsi logic

Stuff known to be broken:
    - iser support. It was weirdly hacked in the old code. I will put a
      code path to preserve backward compatibility.
    - implicit interface creation. As this was never officially
      supported by VDSM I will not bring this back.
    - tpgt is ignores. This is in line with old VDSM behaviour.

Note that the confusing naming is still used by the old API calls for
backward compatibility. New API calls should try and use correct naming
and format!

Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
---
M vdsm.spec.in
M vdsm/constants.py.in
M vdsm/storage/Makefile.am
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
A vdsm/storage/iscsiadm.py
M vdsm/storage/multipath.py
M vdsm/storage/storageProviderConnectionMonitor.py
M vdsm/supervdsmServer.py
9 files changed, 609 insertions(+), 424 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/1607/1
--
To view, visit http://gerrit.ovirt.org/1607
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list