Change in vdsm[master]: contrib: Adding contrib/nfs-check.py
dougsland at redhat.com
dougsland at redhat.com
Fri Feb 3 18:21:42 UTC 2012
Douglas Schilling Landgraf has posted comments on this change.
Change subject: contrib: Adding contrib/nfs-check.py
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File contrib/nfs-check.py
Line 46: self.nfsServer = None
Done
Line 84: if ret != 0 and localMachine == True:
Done
Line 180: print output
Done
Line 197: output = process.communicate()[1].strip()
Indeed, in this case, I am looking only for error output but popen.communicate returns a tuple of stdout stderr that's why I used output. If you prefer, I can change it to errput.
--
To view, visit http://gerrit.ovirt.org/916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list