Change in vdsm[master]: Log exceptions when calling irs functions from XMLRPC

fsimonce at redhat.com fsimonce at redhat.com
Wed Feb 1 16:53:22 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Log exceptions when calling irs functions from XMLRPC
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/BindingXMLRPC.py
Line 161:                     f.im_self.log.error(traceback.format_exc())
Usually log.error("error message", exc_info=True) is preferred.
If traceback wasn't used in wrapApiMethod we could have completely removed the import. Low hanging fruit for anyone interested in cleaning up.

--
To view, visit http://gerrit.ovirt.org/1575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd560d3b110c91f5019c5a6af477926a1fbf1996
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list