Change in vdsm[master]: Add hotPlug/hotUnplug NIC feature

ilvovsky at redhat.com ilvovsky at redhat.com
Wed Feb 1 15:33:06 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Add hotPlug/hotUnplug NIC feature
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File vdsm/BindingXMLRPC.py
Line 245:     def vmHotplugNic(self, params):
Separate patch

....................................................
File vdsm/libvirtvm.py
Line 1314:             if dev.macAddr.lower() == nicParams['macAddr'].lower():
you are right, but we need to do it in several places. So, let's fix it later  on separate patch

Line 1328:             self._devices[vm.NIC_DEVICES].remove(nic)
It's not

Line 1331:         for dev in self.conf['devices'][:]:
Why? It's the same thing

--
To view, visit http://gerrit.ovirt.org/1388
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd56650308f5836913f513fffc179f39fc8f6cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list