Change in vdsm[master]: netinfo: implement functions gathering ipv6 information

assafmuller at gmail.com assafmuller at gmail.com
Sun Dec 16 13:11:46 UTC 2012


Assaf Muller has posted comments on this change.

Change subject: netinfo: implement functions gathering ipv6 information
......................................................................


Patch Set 3: Verified

(1 inline comment)

I answered Dan's question regarding ipv6 address scope.

....................................................
File vdsm/netinfo.py
Line 181: 
Line 182: 
Line 183: def getipv6addrs(dev):
Line 184:     """Return a list of ipv6 addresses in the format of 'address/prefixlen'."""
Line 185:     dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8'))
I checked into it and indeed the address scope of an ipv6 address can be deduced from the address itself, for unicast, anycast and multicast addresses. Here are Microsoft's clear and well written articles about the subject:
http://msdn.microsoft.com/en-us/library/aa921071.aspx - Unicast.
http://msdn.microsoft.com/en-us/library/aa916331.aspx - Anycast.
http://msdn.microsoft.com/en-us/library/aa924142.aspx - Multicast.
Line 186:     ipv6addrs = dev_info_list[0].get_ipv6_addresses()
Line 187:     return ['/'.join([addr.address, str(addr.netmask)]) for addr in ipv6addrs]
Line 188: 
Line 189: 


--
To view, visit http://gerrit.ovirt.org/9381
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2318ffa7d71abe3f57cb5e480bc46565e29f3894
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <assafmuller at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list