Change in vdsm[master]: isRunning didn't check local variable before reading saved d...

danken at redhat.com danken at redhat.com
Mon Dec 31 18:41:41 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: isRunning didn't check local variable before reading saved data
......................................................................


isRunning didn't check local variable before reading saved data

All internal svdsm files contained last svdsm instance info,
after restart we didn't verify local manager instance before processing
the operation and got AttributeError exception when calling svdsm
manager.

This returns false when _svdsm instance is None or in firstLaunch.

Change-Id: I9dec0c6955dadcd959cc1c8df4e9745322fb0ce3
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=890365
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/supervdsm.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Yaniv Bronhaim: Verified
  Dan Kenigsberg: 


--
To view, visit http://gerrit.ovirt.org/10491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9dec0c6955dadcd959cc1c8df4e9745322fb0ce3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list