Change in vdsm[master]: [WIP] remote serial console via HTTP virtual server

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Mon Dec 31 08:57:07 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: [WIP] remote serial console via HTTP virtual server
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 1089:             'displayPort': self.conf['displayPort'],
Line 1090:             'displaySecurePort': self.conf['displaySecurePort'],
Line 1091:             'displayType': self.conf['display'],
Line 1092:             'displayIp': self.conf['displayIp'],
Line 1093:             'consolePath': self.conf['consolePath'],
you have touched the return of getVmStats API.

so  you should update the json schema.
Line 1094:             'pid': self.conf['pid'],
Line 1095:             'vmType': self.conf['vmType'],
Line 1096:             'kvmEnable': self._kvmEnable,
Line 1097:             'network': {}, 'disks': {},


--
To view, visit http://gerrit.ovirt.org/10381
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b2fd0979dac68a7efed4d5bbcb1866cd48a0ccb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list