Change in vdsm[master]: isRunning didn't check local variable before reading saved d...

danken at redhat.com danken at redhat.com
Mon Dec 31 08:50:05 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: isRunning didn't check local variable before reading saved data
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/supervdsm.py
Line 143:         self._svdsm = None
Line 144:         self._firstLaunch = True
Line 145: 
Line 146:     def isRunning(self):
Line 147:         if self._firstLaunch or self._svdsm is None:
sorry, but this fix is raceful: self._firstLaunch is set before self.pidfile is created on disk.
Line 148:             return False
Line 149: 
Line 150:         try:
Line 151:             with open(self.pidfile, "r") as f:


--
To view, visit http://gerrit.ovirt.org/10491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dec0c6955dadcd959cc1c8df4e9745322fb0ce3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list