Change in vdsm[master]: isRunning didn't check local variable before reading saved d...
abaron at redhat.com
abaron at redhat.com
Sun Dec 30 15:06:56 UTC 2012
Ayal Baron has posted comments on this change.
Change subject: isRunning didn't check local variable before reading saved data
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/supervdsm.py
Line 70: if not self._supervdsmProxy.isRunning():
Line 71: self._supervdsmProxy.launch()
Line 72:
Line 73: callMethod = lambda: \
Line 74: getattr(self._supervdsmProxy._svdsm, self._funcName)(*args,
This change is not directly related to the isRunning change and should be separated into another patch. I would gladly +2 this change alone.
Line 75: **kwargs)
Line 76: try:
Line 77: return callMethod()
Line 78: # handling internal exception that we raise to identify supervdsm
Line 143: self._svdsm = None
Line 144: self._firstLaunch = True
Line 145:
Line 146: def isRunning(self):
Line 147: if self._svdsm is None:
shouldn't you try to connect first if _firstLaunch == False ?
Line 148: return False
Line 149:
Line 150: try:
Line 151: with open(self.pidfile, "r") as f:
--
To view, visit http://gerrit.ovirt.org/10491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dec0c6955dadcd959cc1c8df4e9745322fb0ce3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list