Change in vdsm[master]: pool: ignore refreshStoragePool calls on the SPM

vvolansk at redhat.com vvolansk at redhat.com
Sun Dec 30 06:02:22 UTC 2012


Vered Volansky has posted comments on this change.

Change subject: pool: ignore refreshStoragePool calls on the SPM
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1028: 
Line 1029:         return self._disconnectPool(pool, hostID, scsiKey, remove)
Line 1030: 
Line 1031:     def _disconnectPool(self, pool, hostID, scsiKey, remove):
Line 1032:         self.validateNotSPM(pool.spUUID)
This is still being called from destroyStoragePool, only now no checking if this is the SPM. Is this the desired behaviour now? Even if so - is it really safe to remove this from here (might be forgotten about in future calls to this function).
Line 1033:         res = pool.disconnect()
Line 1034:         del self.pools[pool.spUUID]
Line 1035:         return res
Line 1036: 


--
To view, visit http://gerrit.ovirt.org/10450
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c275bfb15e4948c2e28ea21fac787c36bb48e97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list