Change in vdsm[master]: stats: compute the iso prefix asynchronously

vvolansk at redhat.com vvolansk at redhat.com
Sun Dec 30 05:47:41 UTC 2012


Vered Volansky has posted comments on this change.

Change subject: stats: compute the iso prefix asynchronously
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

See minor comment

....................................................
File vdsm/storage/domainMonitor.py
Line 188:             if self.domain is None:
Line 189:                 self.domain = sdCache.produce(self.sdUUID)
Line 190: 
Line 191:             if self.isIsoDomain is None:
Line 192:                 isIsoDomain = self.domain.isISO()
Why not use directly self.isIsoDomain and loose the local variable isIsoDomain (and the last assignment)?
Line 193:                 if isIsoDomain:
Line 194:                     self.isoPrefix = self.domain.getIsoDomainImagesDir()
Line 195:                 self.isIsoDomain = isIsoDomain
Line 196: 


--
To view, visit http://gerrit.ovirt.org/10305
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09b7be78da544547a6ed9d5b440bdb0037004c16
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list