Change in vdsm[master]: adding getHardwareInfo API to vdsm

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Wed Dec 26 14:52:00 UTC 2012


Shu Ming has posted comments on this change.

Change subject: adding getHardwareInfo API to vdsm
......................................................................


Patch Set 19: Looks good to me, but someone else must approve

(1 inline comment)

A nit inline.

....................................................
File vdsm/Makefile.am
Line 31: 	clientIF.py \
Line 32: 	configNetwork.py \
Line 33: 	debugPluginClient.py \
Line 34: 	dummybr.py \
Line 35: 	dmidecodeUtil.py \
It might be more reasonable to move this file into line "dist_vdsmpylib_PYTHON".
Line 36: 	guestIF.py \
Line 37: 	hooking.py \
Line 38: 	hooks.py \
Line 39: 	kaxmlrpclib.py \


--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Andrew Cathrow <andrew at cathrow.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list