Change in vdsm[master]: Improve dom xml gereration

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed Dec 26 03:17:32 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Improve dom xml gereration
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 552: class XMLElem(object):
Line 553: 
Line 554:     def __init__(self, tagName, text=None, attrs={}):
Line 555:         self.doc = xml.dom.minidom.Document()
Line 556:         self.elem = self.doc.createElement(tagName)
I'm OK if you keep it.
Line 557:         self.setAttrs(attrs)
Line 558:         if text is not None:
Line 559:             self.addTextNode(text)
Line 560: 


--
To view, visit http://gerrit.ovirt.org/10054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib936740fcbeeee551e13abfed7fd91f2a159e351
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list