Change in vdsm[master]: prepareForShutdown is not called when connection to libvirt ...

danken at redhat.com danken at redhat.com
Tue Dec 25 13:45:40 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: prepareForShutdown is not called when connection to libvirt is broken.
......................................................................


prepareForShutdown is not called when connection to libvirt is broken.

add few more error codes taken from libvirt's virsh code. In future we should
replace all this with a callback function they are adding in (not in RHEL 6.3).
And perhaps avoid restarting vdsm and re-populate object from the new libvirt
instance instead.

Change-Id: Ic1d9a2cd9bfd7da9118d643d0e50106e5e759590
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=852956
Signed-off-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M vdsm/libvirtconnection.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Leonid Natapov: Verified
  Dan Kenigsberg: Looks good to me, approved
  Peter V. Saveliev: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/8283
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1d9a2cd9bfd7da9118d643d0e50106e5e759590
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov at gmail.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list