Change in vdsm[master]: Adding getBiosInfo API to vdsm cli and merge bios informatio...

Alon Bar-Lev alonbl at redhat.com
Mon Dec 24 15:46:36 UTC 2012


Alon Bar-Lev has posted comments on this change.

Change subject: Adding getBiosInfo API to vdsm cli and merge bios information with vdsGetCaps
......................................................................


Patch Set 15: (1 inline comment)

....................................................
File vdsm/supervdsmServer.py
Line 100: 
Line 101:     @logDecorator
Line 102:     def getDmidecodeInfo(self, *args, **kwargs):
Line 103:         try:
Line 104:             return _getSystemStructure()
Not nice.

Why not perform the platform check and import here?

Also add ppc bios serial (at least).
Line 105:         except:
Line 106:             return {}
Line 107: 
Line 108:     @logDecorator


--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Andrew Cathrow <andrew at cathrow.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list